visibilityManipulator = $visibilityManipulator; $this->reflectionResolver = $reflectionResolver; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Make method visibility same as parent one', [new CodeSample(<<<'CODE_SAMPLE' class ChildClass extends ParentClass { public function run() { } } class ParentClass { protected function run() { } } CODE_SAMPLE , <<<'CODE_SAMPLE' class ChildClass extends ParentClass { protected function run() { } } class ParentClass { protected function run() { } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [Class_::class]; } /** * @param Class_ $node */ public function refactor(Node $node) : ?Node { $classReflection = $this->reflectionResolver->resolveClassReflection($node); if (!$classReflection instanceof ClassReflection) { return null; } if ($classReflection->isAnonymous()) { return null; } $parentClassReflections = $classReflection->getParents(); if ($parentClassReflections === []) { return null; } $hasChanged = \false; $interfaces = $classReflection->getInterfaces(); foreach ($node->getMethods() as $classMethod) { if ($classMethod->isMagic()) { continue; } /** @var string $methodName */ $methodName = $this->getName($classMethod->name); if ($classMethod->isPublic()) { foreach ($interfaces as $interface) { if ($interface->hasNativeMethod($methodName)) { continue 2; } } } foreach ($parentClassReflections as $parentClassReflection) { $nativeClassReflection = $parentClassReflection->getNativeReflection(); // the class reflection above takes also @method annotations into an account if (!$nativeClassReflection->hasMethod($methodName)) { continue; } /** @var ReflectionMethod $parentReflectionMethod */ $parentReflectionMethod = $nativeClassReflection->getMethod($methodName); if ($this->isClassMethodCompatibleWithParentReflectionMethod($classMethod, $parentReflectionMethod)) { continue 2; } $this->changeClassMethodVisibilityBasedOnReflectionMethod($classMethod, $parentReflectionMethod); $hasChanged = \true; } } if ($hasChanged) { return $node; } return null; } private function isClassMethodCompatibleWithParentReflectionMethod(ClassMethod $classMethod, ReflectionMethod $reflectionMethod) : bool { if ($reflectionMethod->isPublic() && $classMethod->isPublic()) { return \true; } if ($reflectionMethod->isProtected() && $classMethod->isProtected()) { return \true; } if (!$reflectionMethod->isPrivate()) { return \false; } return $classMethod->isPrivate(); } private function changeClassMethodVisibilityBasedOnReflectionMethod(ClassMethod $classMethod, ReflectionMethod $reflectionMethod) : void { if ($reflectionMethod->isPublic()) { $this->visibilityManipulator->makePublic($classMethod); return; } if ($reflectionMethod->isProtected()) { $this->visibilityManipulator->makeProtected($classMethod); return; } if ($reflectionMethod->isPrivate()) { $this->visibilityManipulator->makePrivate($classMethod); } } }