safeLeftTypeBooleanAndOrAnalyzer = $safeLeftTypeBooleanAndOrAnalyzer; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Reduce always false in a if ( || ) condition', [new CodeSample(<<<'CODE_SAMPLE' class SomeClass { public function run(int $number) { if (! is_int($number) || $number > 50) { return 'yes'; } return 'no'; } } CODE_SAMPLE , <<<'CODE_SAMPLE' class SomeClass { public function run(int $number) { if ($number > 50) { return 'yes'; } return 'no'; } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [If_::class]; } /** * @param If_ $node */ public function refactor(Node $node) : ?Node { if (!$node->cond instanceof BooleanOr) { return null; } $booleanOr = $node->cond; $conditionStaticType = $this->getType($booleanOr->left); if (!$conditionStaticType instanceof ConstantBooleanType) { return null; } if ($conditionStaticType->getValue()) { return null; } if (!$this->safeLeftTypeBooleanAndOrAnalyzer->isSafe($booleanOr)) { return null; } $node->cond = $booleanOr->right; return $node; } }